Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidelines Hero #458

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Update guidelines Hero #458

merged 2 commits into from
Oct 11, 2023

Conversation

auareyou
Copy link
Contributor

@auareyou auareyou commented Oct 11, 2023

List of notable changes:

  • Replaced images to match the new Hero component.
  • Made a new image for anatomy.
Before After

53245580-7047-413a-b753-df104d4c1870

anatomy

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

⚠️ No Changeset found

Latest commit: b174f5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

🟢 No design token changes found

@auareyou auareyou temporarily deployed to github-pages October 11, 2023 14:48 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

@auareyou auareyou marked this pull request as ready for review October 11, 2023 15:55
Copy link
Contributor

@josepmartins josepmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ✨

@auareyou auareyou merged commit 0e12799 into main Oct 11, 2023
@auareyou auareyou deleted the auareyou-hero branch October 11, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants