Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineLinks inherit text size even with custom css #465

Closed
wants to merge 4 commits into from

Conversation

joseph-lozano
Copy link
Contributor

@joseph-lozano joseph-lozano commented Oct 16, 2023

Summary

Inline Links will now inherit their text size, even when custom CSS is used. Fixes #446

List of notable changes:

  • updated Inline Links will now inherit their text size, even when custom CSS is used.

What should reviewers focus on?

Steps to test:

  1. Go to components-inlinelink--size-inheritence-with-custom-css in Storybook
  2. Verify that the font-size is being inheriting correctly.

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

CleanShot 2023-10-16 at 13 07 55@2x

CleanShot 2023-10-16 at 13 07 32@2x

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 31fe806

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

🟢 No design token changes found

@joseph-lozano joseph-lozano marked this pull request as ready for review October 16, 2023 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a regression on the size prop?

Screen.Recording.2023-10-17.at.09.51.51.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - InlineLink does not inherit size
2 participants