Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Tokens: rm overwrites #758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Sep 17, 2024

Summary

With prefixes now working #727 we should be able to remove a lot of the files that just overwrite tokens with the same tokens that used to have a namespace.

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: fb8f556

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

🔍 Design token changes found

View CSS variable changes
- --brand-borderRadius-full: 624.9375rem; /* Use this border radius for pill shaped elements */
+ --brand-outline-focus-width: 0.125rem;
+ --brand-outline-focus-offset: -0.125rem;
+ --brand-borderRadius-full: 624.9375rem;
+ --brand-borderRadius-large: 0.75rem;
+ --brand-borderRadius-medium: 0.375rem;
+ --brand-borderRadius-small: 0.1875rem;
- --brand-borderRadius-xlarge: var(--base-size-24);
+ --brand-borderRadius-default: var(--brand-borderRadius-medium);
- --brand-borderRadius-large: var(--base-size-16);
+ --brand-boxShadow-thicker: inset 0 0 0 var(--brand-borderWidth-thicker);
- --brand-borderRadius-medium: var(--base-size-8);
+ --brand-boxShadow-thick: inset 0 0 0 var(--brand-borderWidth-thick);
- --brand-borderRadius-small: var(--base-size-4);
+ --brand-boxShadow-thin: inset 0 0 0 var(--brand-borderWidth-thin);
- --brand-control-animation-easing: var(--brand-animation-easing-glide);
+ --brand-overlay-offset: 0.25rem;
- --brand-control-animation-duration: 80ms;
+ --brand-overlay-height-xlarge: 37.5rem;
- --brand-control-large-size: 3.75rem;
+ --brand-overlay-height-large: 27rem;
+ --brand-overlay-height-medium: 20rem;
+ --brand-overlay-height-small: 16rem;
+ --brand-overlay-width-xlarge: 60rem;
+ --brand-overlay-width-large: 40rem;
+ --brand-overlay-width-medium: 30rem;
+ --brand-overlay-width-small: 20rem;
+ --brand-overlay-width-xsmall: 12rem;
+ --brand-spinner-strokeWidth-default: 0.125rem;
+ --brand-control-xlarge-paddingBlock: 0.875rem;
+ --brand-control-large-paddingBlock: 0.625rem;
+ --brand-control-medium-paddingBlock: 0.375rem;
+ --brand-control-xsmall-paddingBlock: 0.125rem;
+ --brand-overlay-borderRadius: var(--brand-borderRadius-medium);
+ --brand-overlay-paddingBlock-normal: var(--base-size-12);
+ --brand-overlay-paddingBlock-condensed: var(--base-size-4);
+ --brand-overlay-padding-condensed: var(--base-size-8);
+ --brand-overlay-padding-normal: var(--base-size-16);
- --brand-stack-gap-spacious: var(--base-size-48);
+ --brand-stack-gap-spacious: var(--base-size-24);
- --brand-stack-gap-normal: var(--base-size-24);
+ --brand-stack-gap-normal: var(--base-size-16);
- --brand-stack-gap-condensed: var(--base-size-16);
+ --brand-stack-gap-condensed: var(--base-size-8);
- --brand-stack-padding-spacious: var(--base-size-48);
+ --brand-stack-padding-spacious: var(--base-size-24);
- --brand-stack-padding-normal: var(--base-size-24);
+ --brand-stack-padding-normal: var(--base-size-16);
- --brand-stack-padding-condensed: var(--base-size-16);
+ --brand-stack-padding-condensed: var(--base-size-8);
- --brand-box-spacing-spacious: var(--base-size-48);
+ --brand-spinner-size-large: var(--base-size-64);
- --brand-box-spacing-normal: var(--base-size-24);
+ --brand-spinner-size-medium: var(--base-size-32);
- --brand-box-spacing-condensed: var(--base-size-16);
+ --brand-spinner-size-small: var(--base-size-16);
- --brand-control-large-gap: var(--base-size-16);
+ --brand-control-xlarge-gap: var(--base-size-8);
- --brand-control-large-paddingInline-spacious: var(--base-size-32);
+ --brand-control-xlarge-paddingInline-spacious: var(--base-size-16);
- --brand-control-large-paddingInline-normal: var(--base-size-20);
+ --brand-control-xlarge-paddingInline-normal: var(--base-size-12);
- --brand-control-large-paddingInline-condensed: var(--base-size-16);
+ --brand-control-xlarge-lineBoxHeight: var(--base-size-20);
- --brand-control-large-paddingBlock: var(--base-size-20);
+ --brand-control-xlarge-size: var(--base-size-48);
+ --brand-control-large-gap: var(--base-size-8);
+ --brand-control-large-paddingInline-spacious: var(--base-size-16);
+ --brand-control-large-paddingInline-normal: var(--base-size-12);
- --brand-control-medium-gap: var(--base-size-12);
+ --brand-control-large-size: var(--base-size-40);
- --brand-control-medium-paddingInline-spacious: var(--base-size-28);
+ --brand-control-medium-gap: var(--base-size-8);
- --brand-control-medium-paddingInline-normal: var(--base-size-16);
+ --brand-control-medium-paddingInline-spacious: var(--base-size-16);
- --brand-control-medium-paddingInline-condensed: var(--base-size-12);
+ --brand-control-medium-paddingInline-normal: var(--base-size-12);
- --brand-control-medium-paddingBlock: var(--base-size-16);
+ --brand-control-medium-paddingInline-condensed: var(--base-size-8);
- --brand-control-medium-lineBoxHeight: var(--base-size-16);
+ --brand-control-medium-lineBoxHeight: var(--base-size-20);
- --brand-control-medium-size: var(--base-size-48);
+ --brand-control-medium-size: var(--base-size-32);
- --brand-control-small-gap: var(--base-size-8);
+ --brand-control-small-gap: var(--base-size-4);
- --brand-control-small-paddingBlock: var(--base-size-8);
+ --brand-control-small-paddingBlock: var(--base-size-4);
- --brand-control-small-lineBoxHeight: var(--base-size-12);
+ --brand-control-small-lineBoxHeight: var(--base-size-20);
- --brand-control-small-size: var(--base-size-32);
+ --brand-control-small-size: var(--base-size-28);
+ --brand-control-xsmall-gap: var(--base-size-4);
+ --brand-control-xsmall-paddingInline-spacious: var(--base-size-12);
+ --brand-control-xsmall-paddingInline-normal: var(--base-size-8);
+ --brand-control-xsmall-paddingInline-condensed: var(--base-size-4);
+ --brand-control-xsmall-lineBoxHeight: var(--base-size-20);
+ --brand-control-xsmall-size: var(--base-size-24);

Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

@lukasoppermann lukasoppermann changed the title rm overwrites Design Tokens: rm overwrites Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant