Skip to content

Release tracking #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Release tracking #821

merged 1 commit into from
Nov 22, 2024

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Nov 18, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

  • #825 2c8e9240 Thanks @rezrah! - Switched to use CSS Logical Properties in compiled output.

    • Compiled styles now directly use CSS logical properties (e.g., margin-inline-start, margin-inline-end) instead of physical properties (margin-left, margin-right).
    • This change simplifies the stylesheet and reduces its overall size (652kB > 593kB)

    Example of the change:

    Source:

    .selector {
      margin-inline-start: var(--base-size-20);
    }
    Previous compiled output New compiled output
    [dir='ltr'] .selector {
      margin-left: 2px;
    }
    
    [dir='rtl'] .selector {
      margin-right: 2px;
    }
    .selector {
      margin-inline-start: 2px;
    }

Patch Changes

  • #825 2c8e9240 Thanks @rezrah! - Fixed errors in compiled CSS stylesheets where selectors with special characters were being unintentionally escaped for compatibility with legacy browsers.

  • #818 281beb08 Thanks @joshfarrant! - FormControl.Validation is now associated with the relevant input using aria-describedby.

  • #822 75da350d Thanks @joshfarrant! - Updated IDEChatMessage type declaration to differentiate between assistant and user messages.

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

Copy link
Contributor

github-actions bot commented Nov 18, 2024

❗ Pre-merge checklist

Please ensure these items are checked before merging.

✅ Preliminary checks

  • All CI checks pass on this pull request
  • Docs and Storybook previews open in a browser

🔌 Integration smoke tests

Dotcom

  • Performed successful integration test with github/github, as a primary consumer of Primer Brand
    • Install RC: bin/npm install --save --save-exact @primer/react-brand@{RC_VERSION}
      Important: Verify that each workspace package has been updated correctly in their respective package.json files
    • Run development server
    • Manually verify release-specific bugfixes and/or features on the following pages:
      • /features/copilot
      • /enterprise
      • /enterprise/advanced-security
      • /articles/security
      • /articles/security/what-is-security-testing
      • /features/preview
      • /features/copilot/getting-started and /features/copilot
      • /solutions/devops
      • /education
      • /mobile
      • /contact-sales
      • /about/diversity
    • Manually compare production site to local instance for any non-release specific regressions

Subdomain sites

  • Performed successful integration test with githubuniverse.com, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production
  • Performed successful integration test with https://resources.github.com/, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production

Sandboxes

  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Cross-check (aka sanity test)

  • Release notes accurately describe the changes made
  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions or side-effects have not been introduced as a result of changes in this release.
    • If they have, determine severity of the issue and consider hotfixing

After tests

  • Add report summary of your findings, including any images. Use following template as a guide:

    #### Smoke test results
    
    - Feature 1 🟢 🟡 🔴 (choose one, depending on success levels)
    
      {insert screenshot}
    
    Release testing status: Ready to release 🟢 | Paused 🟡 🔴 (choose one and provide reason)

🚢 After merge

  • Issue release comms in primer brand Slack channel
  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Copy link
Contributor

github-actions bot commented Nov 18, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Nov 18, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
Copy link
Collaborator

rezrah commented Nov 22, 2024

Smoke test results

- FormControl.Validation is now associated with the relevant input using aria-describedby. 🟢

Tested in dotcom and one other subdomain site that uses form validations, works as expected. Example:

Screenshot 2024-11-22 at 14 38 45

  • Updated IDEChatMessage type declaration to differentiate between assistant and user messages 🟢

    No known usage of component yet, and the change is limited to pre-compile regressions of which none have been detected so far

- Fixed errors in compiled CSS stylesheets where selectors with special characters were being unintentionally escaped for compatibility with legacy browsers. 🟢

The :has selector being parsed as expected in dotcom. Issue verified as having been removed in compiled stylsheet/

- Switched to use CSS Logical Properties in compiled output. 🟢

Biggest change in this release, but with logical properties now part of Baseline browser support it's reasonable to roll this out. Dotcom doesn't consistently apply dir attribute too, which is an improvement to before as it applies the relevant styles regardless of reading direction.

Example:

Before After

Screenshot 2024-11-22 at 14 50 28

Screenshot 2024-11-22 at 14 50 12

Release testing status: Ready to release 🟢

@rezrah rezrah merged commit aafffd9 into main Nov 22, 2024
19 checks passed
@rezrah rezrah deleted the changeset-release/main branch November 22, 2024 14:54
joshfarrant pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants