Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for PricingOptions markup order #855

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

danielguillan
Copy link
Contributor

Summary

Adds a test to verify that PricingOptions renders the markup of its items in the correct, accessible order. Follow up of #812.

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: bf2fa11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 9, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

@danielguillan danielguillan requested a review from rezrah December 9, 2024 16:56
@danielguillan danielguillan merged commit 5a28ff4 into main Dec 10, 2024
17 of 19 checks passed
@danielguillan danielguillan deleted the danielguillan/add-pricing-options-markup-test branch December 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants