Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease default heading size in River #860

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Dec 11, 2024

Summary

Closes https://github.com/github/primer/issues/4402

Also removed CRA test, due to lack of OSS support and low framework adoption.

🔗 Preview

List of notable changes:

  • Decreases the default heading size value in River from 4 to 5.

What should reviewers focus on?

  • Review the diffs for design correctness

Steps to test:

  1. Go the the diffs in 'files changed' tab
  2. Review the before and after visual snapshots
  3. Review the Storybook examples

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

Screenshot 2024-12-11 at 17 56 30

Screenshot 2024-12-11 at 17 56 48

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 39a8b6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Minor
@primer/brand-primitives Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 11, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Dec 11, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@joshfarrant joshfarrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.changeset/big-beans-appear.md Outdated Show resolved Hide resolved
Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@natalie-iv natalie-iv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rezrah rezrah merged commit 2502f65 into main Dec 17, 2024
16 of 17 checks passed
@rezrah rezrah deleted the rezrah/decrease-river-heading-size branch December 17, 2024 12:47
@primer-css primer-css mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants