Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variant support to Hero.Description #867

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Dec 17, 2024

Summary

Resolves #849

Adds support for variant="muted" to Hero.Description.

🔗 See updated docs
🔗 See example

List of notable changes:

  • Extended and forwarded Text props to Hero.Description
  • Updated interface guidelines

What should reviewers focus on?

  • Are the updated guidelines okay?

Steps to test:

  1. Use this Storybook example
  2. Use this documentation link

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Screenshot 2024-12-17 at 18 58 46

Updated docs:
Screenshot 2024-12-17 at 19 38 45

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 91abd45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

🟢 No design token changes found

Copy link
Contributor

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link

@simmonsjenna simmonsjenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rezrah
Copy link
Collaborator Author

rezrah commented Dec 18, 2024

Thanks for the reviews all. cc. @danielguillan to add this into Figma component too.

@rezrah rezrah merged commit 4bac386 into main Dec 18, 2024
16 of 17 checks passed
@rezrah rezrah deleted the rezrah/hero-description-variant branch December 18, 2024 10:46
@primer-css primer-css mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Add "muted" variant to the Hero description
3 participants