Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: fix torchlight card border radius #885

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

joshfarrant
Copy link
Contributor

Summary

Fixes a bug with the torchlight card border radius. See screenshots below and note the discrepancy between the border radius of the border, and the border radius of the background.

Steps to test:

  1. Check that the issue is resolved in Storybook

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Before After

image

image

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: b75de81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshfarrant joshfarrant requested a review from rezrah January 9, 2025 14:57
@joshfarrant joshfarrant marked this pull request as ready for review January 9, 2025 14:57
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🟢 No design token changes found

@joshfarrant joshfarrant mentioned this pull request Jan 9, 2025
@joshfarrant joshfarrant changed the title fix torchlight card border radius hotfix: fix torchlight card border radius Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this..

Regression stemming from here #880 for posterity

@joshfarrant joshfarrant merged commit 4b82e2b into main Jan 9, 2025
16 of 18 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/0.45.1-hotfix branch January 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants