-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements to IDE component colours #904
base: main
Are you sure you want to change the base?
Conversation
|
Name | Type |
---|---|
@primer/react-brand | Patch |
@primer/brand-primitives | Patch |
@primer/brand-e2e | Patch |
@primer/brand-fonts | Patch |
@primer/brand-config | Patch |
@primer/brand-storybook | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
🔍 Design token changes foundView CSS variable changes+ --brand-IDE-default-editor-tab-borderColor: var(--base-color-scale-blue-5); + --brand-IDE-autoSuggest-borderColor: var(--base-color-scale-blue-5); + --brand-IDE-default-editor-tab-borderColor: var(--base-color-scale-blue-5); + --brand-IDE-autoSuggest-borderColor: var(--base-color-scale-blue-5); |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
92f1646
to
bd7048c
Compare
@@ -213,6 +213,7 @@ | |||
|
|||
.IDE__Editor-tab.active { | |||
color: var(--brand-color-text-default); | |||
border-top: 1px solid var(--brand-IDE-default-editor-tab-borderColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-top: 1px solid var(--brand-IDE-default-editor-tab-borderColor); | |
border-top: var(--brand-borderWidth-thin) solid var(--brand-IDE-default-editor-tab-borderColor); |
background-color: var(--brand-IDE-autoSuggestLine-bgColor); | ||
border-left: 1px solid var(--brand-IDE-autoSuggest-borderColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-left: 1px solid var(--brand-IDE-autoSuggest-borderColor); | |
border-left: var(--brand-borderWidth-thin) solid var(--brand-IDE-autoSuggest-borderColor); |
List of notable changes:
IDE
docs about tab contrast on glass variantWhat should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: