Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements to IDE component colours #904

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Jan 23, 2025

List of notable changes:

  • Added note to IDE docs about tab contrast on glass variant
  • Added 1px border to identify active tab and start/end of Copilot suggestion

What should reviewers focus on?

  • Check that you're happy with the borders I've added
  • Check that you're happy with the CSS variable names I've chosen
  • Check that you're happy with the phrasing in the docs

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Before After

image

image

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 0262015

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 23, 2025

🔍 Design token changes found

View CSS variable changes
+ --brand-IDE-default-editor-tab-borderColor: var(--base-color-scale-blue-5);
+ --brand-IDE-autoSuggest-borderColor: var(--base-color-scale-blue-5);
+ --brand-IDE-default-editor-tab-borderColor: var(--base-color-scale-blue-5);
+ --brand-IDE-autoSuggest-borderColor: var(--base-color-scale-blue-5);

Copy link
Contributor

github-actions bot commented Jan 23, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@joshfarrant joshfarrant force-pushed the joshfarrant/ide-use-of-colour branch from 92f1646 to bd7048c Compare January 23, 2025 11:19
@joshfarrant joshfarrant changed the title Add 3:1 contrast identifiers to active tab and copilot suggestion Accessibility improvements to IDE component colours Jan 23, 2025
@@ -213,6 +213,7 @@

.IDE__Editor-tab.active {
color: var(--brand-color-text-default);
border-top: 1px solid var(--brand-IDE-default-editor-tab-borderColor);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-top: 1px solid var(--brand-IDE-default-editor-tab-borderColor);
border-top: var(--brand-borderWidth-thin) solid var(--brand-IDE-default-editor-tab-borderColor);

background-color: var(--brand-IDE-autoSuggestLine-bgColor);
border-left: 1px solid var(--brand-IDE-autoSuggest-borderColor);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-left: 1px solid var(--brand-IDE-autoSuggest-borderColor);
border-left: var(--brand-borderWidth-thin) solid var(--brand-IDE-autoSuggest-borderColor);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants