Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Octicons Description #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Update Octicons Description #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion content/foundations/icons/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ source: https://github.com/primer/octicons
import Icons from '../../../src/components/icons'
import {HeartFillIcon} from '@primer/octicons-react'

A scalable set of icons handcrafted with <HeartFillIcon /> by GitHub
Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see <a href="/foundations/icons/octovisuals">Octovisuals</a>.

<a href="/foundations/icons/design-guidelines">See Design and usage guidelines</a>
Comment on lines +9 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use markdown links here?

Suggested change
Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see <a href="/foundations/icons/octovisuals">Octovisuals</a>.
<a href="/foundations/icons/design-guidelines">See Design and usage guidelines</a>
Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see [Octovisuals](/foundations/icons/octovisuals).
[See Design and usage guidelines](/foundations/icons/design-guidelines)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshBowdenConcepts I was just cleaning up the PRs and saw that this one is pending your input 🙂


<br />
<br />

<Icons />