Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ActionList): add a11y guidance around inline descriptions #884

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 25, 2024

Relates to https://github.com/github/primer/issues/3472

Adds a11y guidance around when it is allowed for ActionList's inline descriptions to truncate text and how to do it via new truncate prop introduced in primer/react#5169

See deployment: https://primer-5f5bfef700-26441320.drafts.github.io/components/action-list#inline-descriptions
Screenshot

proposed InlineDescription guidance screenshot

Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@francinelucca
Copy link
Member Author

TODO: merge when primer/react#5169 gets released

@primer primer deleted a comment from a2425rdl Nov 12, 2024
@francinelucca francinelucca merged commit 85ebf8f into main Nov 15, 2024
6 checks passed
@francinelucca francinelucca deleted the francinelucca/docs/action-list-a11y-guidance branch November 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants