Fix header link redirects #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses header link redirect issues by replacing the Next.js Link component with native anchor tags.
- Replaced the Next.js Link component with an tag for the site title.
- Updated header navigation links to use native anchor tags.
Comments suppressed due to low confidence (2)
packages/theme/components/layout/header/Header.tsx:60
- Replacing the Next.js Link component with a native anchor tag will disable client-side routing, potentially leading to full page reloads. Confirm that this change is intended to achieve the desired redirect behavior.
<a href="/" className={styles.Header__siteTitle}>
packages/theme/components/layout/header/Header.tsx:75
- Ensure that using native anchor tags for header navigation links does not unintentionally bypass Next.js client-side navigation, as this may affect performance due to full page reloads.
<a
danielguillan
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/github/primer/issues/5379
Errors on primer.style indicate that using the Next
Linkcomponent is triggering a prefetch of the reverse-proxied urls, which are failing.This PR switches from
Linkto<a>to prevent the prefetch, while making minimal user-facing changes. These links don't need prefetching.To test this feature resolves the parent Issue, we'll need to ship to production on Primer Brand and verify.