[Breaking] Remove no-deprecated-colors plugin#169
Merged
langermank merged 3 commits intomainfrom May 13, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 306b19f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
approved these changes
May 13, 2024
Member
siddharthkp
left a comment
siddharthkp
left a comment
There was a problem hiding this comment.
Did not find any instances of eslint ignore comment either (https://github.com/search?q=repo%3Agithub%2Fgithub%20no-deprecated-colors&type=code)
Merged
langermank
added a commit
that referenced
this pull request
May 13, 2024
This reverts commit 2576a9f.
langermank
added a commit
that referenced
this pull request
May 13, 2024
This reverts commit 2576a9f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin relies on an older part of the
primer/primitivesbuild and doesn't seem necessary anymore with the move towards CSS variables. We will likely want to introduce a newer version of this plugin in the future, but for now I think it make sense to just remove it and cut a major.no-deprecated-colorspluginprimer/primitives