Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sparkles icon #1041

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Add new sparkles icon #1041

merged 4 commits into from
Dec 4, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Nov 29, 2024

This icon was request by @dthoma1.

Fixes https://github.com/github/primer/issues/4430

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: d2ddaae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this sparkles-fill? That leaves the option to have an outline version in the future and is consistent with the existing sparkle-fill icon: https://primer.style/foundations/icons/sparkle-fill-16

@dthoma1
Copy link

dthoma1 commented Dec 2, 2024

This icon fits our needs for the docs ai assistant project. ✨

@lukasoppermann
Copy link
Contributor Author

lukasoppermann commented Dec 3, 2024

@colebemis is there a naming convention for icons somewhere?

Also: Updated to sparkles-fill

@colebemis
Copy link
Contributor

@colebemis is there a naming convention for icons somewhere?

I don't think so 😞

@tallys
Copy link
Contributor

tallys commented Dec 4, 2024

@colebemis you are a gem and an eternal champion of Octicons, thank you for reviewing!
@lukasoppermann thanks so much for pushing this through to support @dthoma1 !!!

@lukasoppermann lukasoppermann merged commit ef89a78 into main Dec 4, 2024
11 checks passed
@lukasoppermann lukasoppermann deleted the @lukasoppermann/sparkles branch December 4, 2024 13:42
@primer primer bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants