-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sparkles icon #1041
Add new sparkles icon #1041
Conversation
🦋 Changeset detectedLatest commit: d2ddaae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this sparkles-fill
? That leaves the option to have an outline version in the future and is consistent with the existing sparkle-fill
icon: https://primer.style/foundations/icons/sparkle-fill-16
This icon fits our needs for the docs ai assistant project. ✨ |
@colebemis is there a naming convention for icons somewhere? Also: Updated to |
a6a8d0c
to
09ba160
Compare
I don't think so 😞 |
@colebemis you are a gem and an eternal champion of Octicons, thank you for reviewing! |
This icon was request by @dthoma1.
Fixes https://github.com/github/primer/issues/4430