Skip to content

Remove tests that are useless now that I merged the themed json files… #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

lukasoppermann
Copy link
Contributor

… into one file each

Those tests were checking if we missed tokens in the json file, however we now use a different file structure so that the tests don't make sense anymore.

@Copilot Copilot AI review requested due to automatic review settings June 14, 2025 07:14
@lukasoppermann lukasoppermann requested review from a team as code owners June 14, 2025 07:14
Copy link

changeset-bot bot commented Jun 14, 2025

⚠️ No Changeset found

Latest commit: 7ffc856

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete token/theme diff scripts and their tests, and cleans up the validate:tokenJson npm script now that theming files have been consolidated.

  • Deleted the legacy diffTokenProps.ts script.
  • Deleted the legacy diffThemes.ts script and its tests.
  • Removed the validate:tokenJson command from package.json.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/diffTokenProps.ts Removed legacy token comparison script
scripts/diffThemes.ts Removed legacy theme diff script
scripts/diffThemes.test.ts Removed tests for diffThemes
package.json Removed validate:tokenJson npm script
Comments suppressed due to low confidence (3)

scripts/diffTokenProps.ts:1

  • Since this script and its JSON5 usage are removed, consider cleaning up the json5 dependency from package.json if it’s no longer used elsewhere.
import JSON5 from 'json5'

scripts/diffThemes.ts:1

  • With this theme-diff script removed, verify if the style-dictionary package is still needed in your dependencies and remove it if it isn’t used elsewhere.
import {PrimerStyleDictionary} from '../src/primerStyleDictionary.js'

package.json:31

  • [nitpick] Ensure any project documentation or CI workflows referencing npm run validate:tokenJson are updated or removed to prevent broken commands.
"validate:tokenJson": "tsx scripts/diffThemes.ts && tsx scripts/diffTokenProps.ts",

@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 14, 2025 07:16 Inactive
@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Jun 15, 2025
@lukasoppermann lukasoppermann merged commit dff7d80 into main Jun 17, 2025
31 of 32 checks passed
@lukasoppermann lukasoppermann deleted the rm-validate-tokenJson branch June 17, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants