-
Notifications
You must be signed in to change notification settings - Fork 54
Add scss feature flag option #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for using SCSS feature flags as an alternative option for feature flag testing. The change provides developers with guidance on implementing CSS-based feature flags alongside the existing bundle creation approach.
- Adds a new "SCSS feature flag" option with documentation and code examples
- Restructures existing content by renaming the bundle creation section to "Option 2"
- Includes a reference link to implementation details and usage patterns
> Note: these flags are all automatically preloaded | ||
|
||
```scss | ||
* CSS feature flags can be used in any scss/css file like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should use consistent capitalization. 'CSS' should be 'SCSS' to match the section title, or 'SCSS/CSS' to be more inclusive.
* CSS feature flags can be used in any scss/css file like this: | |
* SCSS/CSS feature flags can be used in any scss/css file like this: |
Copilot uses AI. Check for mistakes.
* [data-css-features~="my_feature_flag" i] { | ||
* // styles behind flag | ||
* } | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space and asterisk on this line that should be removed to clean up the code block formatting.
* |
Copilot uses AI. Check for mistakes.
Add scss feature flag option to docs