Skip to content

Add scss feature flag option #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025

Conversation

lukasoppermann
Copy link
Contributor

Add scss feature flag option to docs

@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 07:51
@lukasoppermann lukasoppermann requested review from a team as code owners July 8, 2025 07:51
@lukasoppermann lukasoppermann requested a review from langermank July 8, 2025 07:51
Copy link

changeset-bot bot commented Jul 8, 2025

⚠️ No Changeset found

Latest commit: 7722ed8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for using SCSS feature flags as an alternative option for feature flag testing. The change provides developers with guidance on implementing CSS-based feature flags alongside the existing bundle creation approach.

  • Adds a new "SCSS feature flag" option with documentation and code examples
  • Restructures existing content by renaming the bundle creation section to "Option 2"
  • Includes a reference link to implementation details and usage patterns

> Note: these flags are all automatically preloaded

```scss
* CSS feature flags can be used in any scss/css file like this:
Copy link
Preview

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should use consistent capitalization. 'CSS' should be 'SCSS' to match the section title, or 'SCSS/CSS' to be more inclusive.

Suggested change
* CSS feature flags can be used in any scss/css file like this:
* SCSS/CSS feature flags can be used in any scss/css file like this:

Copilot uses AI. Check for mistakes.

* [data-css-features~="my_feature_flag" i] {
* // styles behind flag
* }
*
Copy link
Preview

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space and asterisk on this line that should be removed to clean up the code block formatting.

Suggested change
*

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 8, 2025 07:58 Inactive
@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Jul 8, 2025
@lukasoppermann lukasoppermann merged commit 9fb1c7d into main Jul 8, 2025
27 checks passed
@lukasoppermann lukasoppermann deleted the lukasoppermann-scss-feature-flag-docs branch July 8, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants