Skip to content

Commit

Permalink
Remove sxProp from SelectPanel
Browse files Browse the repository at this point in the history
  • Loading branch information
JelloBagel committed Dec 12, 2024
1 parent d544f64 commit 5dcd46f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/long-swans-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Remove sxProp from SelectPanel
3 changes: 1 addition & 2 deletions packages/react/src/SelectPanel/SelectPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ export function SelectPanel({
footer,
textInputProps,
overlayProps,
sx,
className,
...listProps
}: SelectPanelProps): JSX.Element {
Expand Down Expand Up @@ -265,7 +264,7 @@ export function SelectPanel({
inputRef={inputRef}
// inheriting height and maxHeight ensures that the FilteredActionList is never taller
// than the Overlay (which would break scrolling the items)
sx={enabled ? sx : {...sx, height: 'inherit', maxHeight: 'inherit'}}
sx={enabled ? undefined : {height: 'inherit', maxHeight: 'inherit'}}
className={enabled ? clsx(className, classes.FilteredActionList) : className}
/>
{footer && (
Expand Down

0 comments on commit 5dcd46f

Please sign in to comment.