Dialog: fix broken stories for Dialog v1 and v2 #4762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
commented
Jul 21, 2024
| @@ -59,7 +60,12 @@ const components = docsFiles.map(docsFilepath => { | |||
| const componentName = isComponentV2 ? `${docsName}v2` : docsName | |||
|
|
|||
| // Get the default story id | |||
| const defaultStoryId = `${storyPrefix[docs.status]}components-${componentName}--default` | |||
| let defaultStoryId = `${storyPrefix[docs.status]}components-${componentName}--default` | |||
There was a problem hiding this comment.
I don't like this but couldn't think of another way to accommodate Dialog customisation. Let me know if you have any recommendation 🙌🏻
TylerJDev
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we have customisation for Dialog stories.
This is Dialog Alpha: https://primer.style/react/storybook/?path=/story/components-dialogv1--default&globals=colorScheme:light
This is Dialog Draft (What we recommend): https://primer.style/react/storybook/?path=/story/components-dialog--default&globals=colorScheme:light
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing