Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Fix storybook issues #4769

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Jul 23, 2024

Closes https://github.com/github/primer/issues/3484, https://github.com/github/primer/issues/3421

Fixes issue where adding an item in our "add new item" story causes an error. Also adds onto existing Autocomplete story to portray a more accessible example.

Changelog

Changed

  • Fixes Autocomplete stories

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: a2ffece

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 23, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.37 KB (0%)
packages/react/dist/browser.umd.js 92.69 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4769 July 23, 2024 15:32 Inactive
@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Jul 23, 2024
@TylerJDev TylerJDev added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit d79f6d5 Jul 25, 2024
34 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/autocomplete-story-fixes branch July 25, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants