Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributor docs] Component Lifecycle proposal #4775

Closed
wants to merge 5 commits into from

Conversation

tbenning
Copy link
Contributor

@tbenning tbenning commented Jul 25, 2024

Internal docs for contributors to better understand our component lifecycle.

Problems

  • Alpha and beta status is confusing for folks
  • We don't communicate that something is being planned for deprecation

New

New documentation around how we approach component lifecycle.

Testing & Reviewing

Content needs to be reviewed and agreement formed around naming conventions.

Merge checklist

Copy link

changeset-bot bot commented Jul 25, 2024

⚠️ No Changeset found

Latest commit: aa80b61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tbenning tbenning added the skip changeset This change does not need a changelog label Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.76 KB (0%)
packages/react/dist/browser.umd.js 96.06 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4775 July 25, 2024 03:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4775 July 25, 2024 04:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4775 July 30, 2024 04:28 Inactive
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 28, 2024
@lesliecdubs
Copy link
Member

Hey @tbenning, noticed this is going stale. Were you ready for engineering-reviewers to jump in? If so, could you please mark as "ready for review" and I'll keep an eye out to make sure we get some movement here?

@github-actions github-actions bot removed the Stale label Oct 4, 2024
@langermank
Copy link
Contributor

Closing for now, feel free to reopen!

@langermank langermank closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants