Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove SSRProvider and useSSRSafeId #4783

Merged
merged 6 commits into from
Aug 14, 2024
Merged

refactor: remove SSRProvider and useSSRSafeId #4783

merged 6 commits into from
Aug 14, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jul 26, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3664

Changelog

New

Changed

  • Update files to no longer use SSRProvider

Removed

  • Remove the SSRProvider component
  • Remove the useSSRSafeId hook

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

Consumers can safely drop the SSRProvider from their projects. For useSSRSafeId, they can safely migrate to useId() in React 18

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 55fc0f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.96 KB (-0.1% 🔽)
packages/react/dist/browser.umd.js 96.27 KB (-0.02% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4783 July 26, 2024 18:32 Inactive
@joshblack joshblack marked this pull request as ready for review August 7, 2024 16:03
@joshblack joshblack requested a review from a team as a code owner August 7, 2024 16:03
@joshblack joshblack requested a review from TylerJDev August 7, 2024 16:03
@github-actions github-actions bot temporarily deployed to storybook-preview-4783 August 7, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4783 August 9, 2024 17:29 Inactive
broccolinisoup
broccolinisoup approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@joshblack joshblack enabled auto-merge August 12, 2024 14:42
@github-actions github-actions bot temporarily deployed to storybook-preview-4783 August 12, 2024 14:46 Inactive
@joshblack joshblack added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 7c57f40 Aug 14, 2024
30 checks passed
@joshblack joshblack deleted the refactor/remove-ssrprovider branch August 14, 2024 16:09
@primer primer bot mentioned this pull request Aug 14, 2024
Merged
jonrohan pushed a commit that referenced this pull request Aug 15, 2024
@joshblack @jonrohan
refactor: remove SSRProvider and useSSRSafeId (#4783)
68ad08b 
* refactor: remove SSRProvider and useSSRSafeId

* chore: remove unused eslint disables

* chore: remove unused prop

---------

Co-authored-by: Josh Black <[email protected]>
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @broccolinisoup