Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributor docs/ADR] Before component deprecation #4788

Closed
wants to merge 1 commit into from

Conversation

tbenning
Copy link
Contributor

Adding new docs to create a better process for what steps to take before component deprecation.

Problem

  • Internally, we don't have a clear process for how to decide that we want to deprecate a component
  • Externally, consumers will use or ask about components that we have tentatively decided to deprecate, but we have no spent the engineering effort to deprecate in a major release.

Merge checklist

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 5b61769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.58 KB (0%)
packages/react/dist/browser.umd.js 95.97 KB (0%)

Copy link
Member

@lesliecdubs lesliecdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for thought!

Are you actively looking for Primer engineer feedback at this stage of the doc? If so, I can help boost visibility to get you some more reviews, if you're ready for that.

- Add to the upcoming Primer release proposals issue.

2. **Team consensus**:
- Obtain agreement from the team that deprecating the component is the best course of action.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if seeking consensus is the best model for decision-making here, as it could slow down our tempo 🤔 I know the GitHub way is to aim for a "consult and decide" model; how might we put that model into action here?


2. **Team consensus**:
- Obtain agreement from the team that deprecating the component is the best course of action.
- Bring a component to Primer Patterns and present to get consensus.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to do this without requiring live/meeting-based participation in order to support our async culture / distributed teammates?

Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 26, 2024
@github-actions github-actions bot closed this Nov 2, 2024
@github-actions github-actions bot deleted the tbenning/before-deprecation branch November 2, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants