-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Contributor docs/ADR] Before component deprecation #4788
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments for thought!
Are you actively looking for Primer engineer feedback at this stage of the doc? If so, I can help boost visibility to get you some more reviews, if you're ready for that.
- Add to the upcoming Primer release proposals issue. | ||
|
||
2. **Team consensus**: | ||
- Obtain agreement from the team that deprecating the component is the best course of action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if seeking consensus is the best model for decision-making here, as it could slow down our tempo 🤔 I know the GitHub way is to aim for a "consult and decide" model; how might we put that model into action here?
|
||
2. **Team consensus**: | ||
- Obtain agreement from the team that deprecating the component is the best course of action. | ||
- Bring a component to Primer Patterns and present to get consensus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to do this without requiring live/meeting-based participation in order to support our async culture / distributed teammates?
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Adding new docs to create a better process for what steps to take before component deprecation.
Problem
Merge checklist