Skip to content

chore(deps): update @primer/octicons-react to 19.14.0#5422

Merged
lukasoppermann merged 10 commits intomainfrom
chore/update-octicons-react-in-lockfile
Jan 9, 2025
Merged

chore(deps): update @primer/octicons-react to 19.14.0#5422
lukasoppermann merged 10 commits intomainfrom
chore/update-octicons-react-in-lockfile

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Dec 12, 2024

Update @primer/octicons-react to latest

Changelog

New

Changed

  • Update @primer/octicons-react to 19.14.0
  • Update how Octicon forwards along the sx prop since this will now be spread on icon components

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Selected minor here since this is a notable change to @primer/octicons-react that we might need to coordinate around.

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: d68eca3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.18 KB (+0.3% 🔺)
packages/react/dist/browser.umd.js 104.52 KB (+0.32% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5422 December 12, 2024 16:13 Inactive
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 12, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 12, 2024
@primer primer bot temporarily deployed to github-pages December 12, 2024 16:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5422 December 12, 2024 16:32 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5422 December 18, 2024 12:49 Inactive
@lukasoppermann lukasoppermann marked this pull request as ready for review December 18, 2024 12:58
@lukasoppermann lukasoppermann requested review from a team as code owners December 18, 2024 12:58
@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Dec 18, 2024
@langermank
Copy link
Contributor

I think we should hold off on merging this until we can address the strange sx issue. I bumped PRC to 19.13.0 so we're a bit more up to date in the meantime.

@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jan 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5422 January 7, 2025 17:02 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jan 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5422 January 7, 2025 17:15 Inactive
@lukasoppermann lukasoppermann added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 37901a8 Jan 9, 2025
43 checks passed
@lukasoppermann lukasoppermann deleted the chore/update-octicons-react-in-lockfile branch January 9, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants