feat(NavList) Convert to CSS Modules #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3b80917 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* copy * copy all * fix padding * add heading * fix selectpanel story * vrt * alignment * moar fixes * dev stories * tests * moving tests around * tests * tests * Apply suggestions from code review * prettier * lint * test(vrt): update snapshots * fix nesting issue * reset * test(vrt): update snapshots * vrt * cleanup * reset * test(vrt): update snapshots * very sad and annoying * snaps * Create dirty-nails-applaud.md * reduce margin on divider * remove truncation e2e test * snappers * lint * test(vrt): update snapshots * fix navlist group * Update packages/react/src/ActionList/Visuals.tsx Co-authored-by: Josh Black <[email protected]> * test classname on visuals * add e2e * use common ff * feat(NavList) Convert to CSS Modules (#5424) * navlist * fix sub item * fix margin * fixies * Create quick-items-hunt.md * not sure how to make this test pass * prettier * logging test failure * reset * test(vrt): update snapshots * remove flaky test * fix changeset * fix active color var * big oops * remove transitions for now * haha * fix trailing visual as text + add test * test(vrt): update snapshots --------- Co-authored-by: langermank <[email protected]> Co-authored-by: Josh Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4297
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist