Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Table): update to CSS Modules #5435

Merged
merged 16 commits into from
Dec 19, 2024
Merged

refactor(Table): update to CSS Modules #5435

merged 16 commits into from
Dec 19, 2024

Conversation

joshblack
Copy link
Member

Closes https://github.com/github/primer/issues/4307

Update Table to CSS Modules behind the team feature flag.

Changelog

New

Changed

  • Update Table to CSS Modules behind a feature flag
  • Update Table sub-components to an easier-to-migrate form of styled-components

Removed

Rollout strategy

  • Minor release

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b500884

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5435 December 13, 2024 16:15 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.65 KB (0%)
packages/react/dist/browser.umd.js 104.99 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5435 December 13, 2024 16:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5435 December 13, 2024 17:09 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355809

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 18, 2024
@JelloBagel JelloBagel marked this pull request as ready for review December 18, 2024 20:34
@JelloBagel JelloBagel requested a review from a team as a code owner December 18, 2024 20:34
@jonrohan jonrohan added this pull request to the merge queue Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@primer primer bot temporarily deployed to github-pages December 18, 2024 23:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5435 December 18, 2024 23:56 Inactive
@jonrohan jonrohan enabled auto-merge December 18, 2024 23:58
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5435 December 19, 2024 00:57 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5435 December 19, 2024 01:30 Inactive
@JelloBagel JelloBagel self-assigned this Dec 19, 2024
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 5cba52a Dec 19, 2024
42 checks passed
@jonrohan jonrohan deleted the refactor/update-table-to-css-modules branch December 19, 2024 19:24
@primer primer bot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@tbenning tbenning Awaiting requested review from tbenning tbenning was automatically assigned from primer/design-reviewers

Assignees

@JelloBagel JelloBagel

Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshblack @hussam-i-am @langermank @jonrohan @JelloBagel