Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deprecate Box sx prop #5459

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Don't deprecate Box sx prop #5459

merged 1 commit into from
Dec 18, 2024

Conversation

jonrohan
Copy link
Member

I missed this in #5443

We don't want to deprecate Box's use of sx prop because it only is used for sx. We will likely follow up with a deprecation pr for Box

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner December 18, 2024 22:38
@jonrohan jonrohan requested a review from camertron December 18, 2024 22:38
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 6211e2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan added the skip changeset This change does not need a changelog label Dec 18, 2024
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 18, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.33 KB (0%)
packages/react/dist/browser.umd.js 103.67 KB (0%)

@jonrohan jonrohan enabled auto-merge December 18, 2024 23:18
@jonrohan jonrohan added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 300c3b9 Dec 18, 2024
48 of 49 checks passed
@jonrohan jonrohan deleted the dont_deprecate_box_sx_prop branch December 18, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants