Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Select): Remove CSS modules feature flag from Select #5464

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 18, 2024

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from Select

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 94122a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 19, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 19, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5464 December 19, 2024 00:02 Inactive
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.32 KB (-0.21% 🔽)
packages/react/dist/browser.umd.js 104.68 KB (-0.28% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355954

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@jonrohan jonrohan marked this pull request as ready for review December 19, 2024 17:47
@jonrohan jonrohan requested a review from a team as a code owner December 19, 2024 17:47
@jonrohan jonrohan requested a review from langermank December 19, 2024 17:47
@jonrohan jonrohan added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@jonrohan jonrohan added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit d43f27f Dec 19, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_remove_select branch December 19, 2024 19:05
@primer primer bot mentioned this pull request Dec 19, 2024
francinelucca added a commit that referenced this pull request Jan 6, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
@jonrohan jonrohan restored the css_modules_remove_select branch January 8, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants