Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set static date in DataTable feature stories #5487

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jan 2, 2025

The difference in how months/days are rendered will cause the table to grow/shrink depending on the date for the "With Overflow" DataTable story, which is going to constantly generate VRT failures. Setting to static date instead.

Changelog

Changed

  • packages/react/src/DataTable/DataTable.features.stories.tsx: set static 09/05/2024 date instead of dynamically generated for story.
  • update snapshots

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Docs only update

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: acb106b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 2, 2025
@francinelucca francinelucca added the skip changeset This change does not need a changelog label Jan 2, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5487 January 2, 2025 19:41 Inactive
Copy link
Contributor

github-actions bot commented Jan 2, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.7 KB (0%)
packages/react/dist/browser.umd.js 104.15 KB (0%)

@primer primer bot temporarily deployed to github-pages January 2, 2025 20:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5487 January 2, 2025 20:33 Inactive
@@ -123,7 +123,7 @@ const data: Array<Repo> = [
id: 8,
name: 'docker-templates',
type: 'public',
updatedAt: now - 3 * Month,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the difference in how months/days are rendered will cause the table to grow/shrink depending on the date, which is going to constantly generate VRT failures. setting to static date instead

@francinelucca francinelucca changed the title TEST fix: Set static date in DataTable feature stories Jan 3, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5487 January 3, 2025 17:21 Inactive
@francinelucca francinelucca added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 51065d6 Jan 3, 2025
47 checks passed
@francinelucca francinelucca deleted the francinelucca-patch-1 branch January 3, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants