-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set static date in DataTable feature stories #5487
Conversation
|
size-limit report 📦
|
@@ -123,7 +123,7 @@ const data: Array<Repo> = [ | |||
id: 8, | |||
name: 'docker-templates', | |||
type: 'public', | |||
updatedAt: now - 3 * Month, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the difference in how months/days are rendered will cause the table to grow/shrink depending on the date, which is going to constantly generate VRT failures. setting to static date instead
The difference in how months/days are rendered will cause the table to grow/shrink depending on the date for the "With Overflow" DataTable story, which is going to constantly generate VRT failures. Setting to static date instead.
Changelog
Changed
Rollout strategy
Docs only update
Testing & Reviewing
Merge checklist