Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Revert "feat(ActionList sub components) Convert to CSS Modules" #5513

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "feat(ActionList sub components) Convert to CSS Modules (#5398)"
This reverts commit 215d8e6.
francinelucca authored Jan 9, 2025
commit cd82125ff124631f4460491675a0f4e35d0db8b9
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
115 changes: 27 additions & 88 deletions e2e/components/ActionList.test.ts
Original file line number Diff line number Diff line change
@@ -313,38 +313,33 @@ test.describe('ActionList', () => {
}
})

// removing this temporarily as there is a slight diff betqeen default and enabled CSS feature flag that feels like a non-issue
// eslint-disable-next-line jest/no-commented-out-tests
// test.describe('Text Wrap And Truncation', () => {
// for (const theme of themes) {
// eslint-disable-next-line jest/no-commented-out-tests
// test.describe(theme, () => {
// eslint-disable-next-line jest/no-commented-out-tests
// test('default @vrt', async ({page}) => {
// await visit(page, {
// id: 'components-actionlist-features--text-wrap-and-truncation',
// globals: {
// colorScheme: theme,
// },
// })

// // Default state
// expect(await page.screenshot()).toMatchSnapshot(`ActionList.Text Wrap And Truncation.${theme}.png`)
// })

// eslint-disable-next-line jest/no-commented-out-tests
// test('axe @aat', async ({page}) => {
// await visit(page, {
// id: 'components-actionlist-features--text-wrap-and-truncation',
// globals: {
// colorScheme: theme,
// },
// })
// await expect(page).toHaveNoViolations()
// })
// })
// }
// })
test.describe('Text Wrap And Truncation', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-actionlist-features--text-wrap-and-truncation',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot()).toMatchSnapshot(`ActionList.Text Wrap And Truncation.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-actionlist-features--text-wrap-and-truncation',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations()
})
})
}
})

test.describe('With Avatars', () => {
for (const theme of themes) {
@@ -745,60 +740,4 @@ test.describe('ActionList', () => {
})
}
})

test.describe('Visuals with Classnames', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-actionlist-dev--visual-custom-classname',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot()).toMatchSnapshot(`Visuals with Classnames.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-actionlist-dev--visual-custom-classname',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations()
})
})
}
})

test.describe('Link Item Options', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-actionlist-examples--list-link-item',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot()).toMatchSnapshot(`Link Item Options.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-actionlist-examples--list-link-item',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations()
})
})
}
})
})

This file was deleted.

24 changes: 0 additions & 24 deletions packages/react/src/ActionList/ActionList.dev.stories.tsx
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@ import {Group} from './Group'
import {Divider} from './Divider'
import {Description} from './Description'
import Avatar from '../Avatar'
import {FileDirectoryIcon, HeartFillIcon} from '@primer/octicons-react'

export default {
title: 'Components/ActionList/Dev',
@@ -145,26 +144,3 @@ export const HeadingCustomClassname = () => (
</ActionList.Group>
</ActionList>
)

export const DescriptionCustomClassname = () => (
<ActionList>
<ActionList.Item>
Label
<ActionList.Description className="testCustomClassnameColor">This is a description</ActionList.Description>
</ActionList.Item>
</ActionList>
)

export const VisualCustomClassname = () => (
<ActionList>
<ActionList.Item>
Label
<ActionList.LeadingVisual className="testCustomClassnameColor">
<FileDirectoryIcon />
</ActionList.LeadingVisual>
<ActionList.TrailingVisual className="testCustomClassnameColor">
<HeartFillIcon />
</ActionList.TrailingVisual>
</ActionList.Item>
</ActionList>
)
14 changes: 1 addition & 13 deletions packages/react/src/ActionList/ActionList.examples.stories.tsx
Original file line number Diff line number Diff line change
@@ -94,21 +94,9 @@ export const ListLinkItem = () => (
<ActionList.LeadingVisual>
<LinkIcon />
</ActionList.LeadingVisual>
With inline description
ActionList.LinkItem with everything
<ActionList.Description variant="inline">inline description</ActionList.Description>
</ActionList.LinkItem>
<ActionList.LinkItem href="?path=/story/components-actionlist--default">
<ActionList.LeadingVisual>
<LinkIcon />
</ActionList.LeadingVisual>
With block description
<ActionList.Description variant="block">Block description</ActionList.Description>
</ActionList.LinkItem>
<ActionList.LinkItem href="?path=/story/components-actionlist--default">
<ActionList.LeadingVisual>
<LinkIcon />
</ActionList.LeadingVisual>
Trailing visual
<ActionList.TrailingVisual>⌘ + L</ActionList.TrailingVisual>
</ActionList.LinkItem>
</ActionList>
Loading