-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionBar: convert to CSS Modules + add new flush
prop to adjust padding
#5540
Conversation
🦋 Changeset detectedLatest commit: 548e483 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358723 |
🔴 golden-jobs completed with status |
The integration test failures are unrelated and have been fixed elsewhere 👍 |
flush
prop to adjust padding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as we're ok with the visual spacing changes design-wise
Closes https://github.com/github/primer/issues/4624
Adds a new
flush
prop to handle padding. Also converts to CSS Modules since there's very little usage.Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist