Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionBar: convert to CSS Modules + add new flush prop to adjust padding #5540

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jan 14, 2025

Closes https://github.com/github/primer/issues/4624

Adds a new flush prop to handle padding. Also converts to CSS Modules since there's very little usage.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 548e483

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 14, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Jan 14, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.13 KB (-0.1% 🔽)
packages/react/dist/browser.umd.js 104.46 KB (-0.11% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358723

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 21, 2025
@langermank
Copy link
Contributor Author

The integration test failures are unrelated and have been fixed elsewhere 👍

@langermank langermank changed the title Actionbar tlc ActionBar: convert to CSS Modules + add new flush prop to adjust padding Jan 22, 2025
@langermank langermank marked this pull request as ready for review January 22, 2025 00:25
@langermank langermank requested review from a team as code owners January 22, 2025 00:25
@langermank langermank added this pull request to the merge queue Jan 22, 2025
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we're ok with the visual spacing changes design-wise

Merged via the queue into main with commit 20788da Jan 22, 2025
43 checks passed
@langermank langermank deleted the actionbar-tlc branch January 22, 2025 00:43
@primer primer bot mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants