Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Deploy preview with VRT/AAT reports (Take Two)" #5543

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Revert "Deploy preview with VRT/AAT reports (Take Two)" #5543

merged 1 commit into from
Jan 14, 2025

Conversation

hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Jan 14, 2025 •
edited
Loading

Reverts #5537

Looks like it is still deploying to production :/

@hussam-i-am hussam-i-am requested a review from a team as a code owner January 14, 2025 18:10
@hussam-i-am hussam-i-am requested a review from joshblack January 14, 2025 18:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: fa92c1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

langermank
langermank approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw man!

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.18 KB (0%)
packages/react/dist/browser.umd.js 104.52 KB (0%)

@hussam-i-am hussam-i-am added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 98b5456 Jan 14, 2025
46 of 47 checks passed
@hussam-i-am hussam-i-am deleted the revert-5537-revert-5536-chore/remove-deploy-previews branch January 14, 2025 18:26
@hussam-i-am hussam-i-am self-assigned this Jan 14, 2025
hussam-i-am added a commit that referenced this pull request Jan 14, 2025
@hussam-i-am
Revert "Revert "Deploy preview with VRT/AAT reports (Take Two) (#5537)…
73a22da 
…" (#5543)"

This reverts commit 98b5456.
@hussam-i-am hussam-i-am mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@joshblack joshblack Awaiting requested review from joshblack joshblack is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@hussam-i-am hussam-i-am

Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussam-i-am @langermank