Skip to content

chore(SelectPanel2): Remove the css modules feature flag from the SelectPanel2 experimental component #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

chore(SelectPanel2): Remove the css modules feature flag from the SelectPanel2 experimental component #6051

merged 3 commits into from
May 21, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented May 15, 2025 •
edited
Loading

Changelog

New

Changed

Removed

Remove the css modules feature flag from the SelectPanel2 experimental component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 15e56cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.26 KB (0%)
packages/react/dist/browser.umd.js 95.31 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-6051 May 15, 2025 18:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6051 May 15, 2025 21:50 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/379053

@jonrohan jonrohan marked this pull request as ready for review May 21, 2025 00:05
@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 00:05
@jonrohan jonrohan requested a review from a team as a code owner May 21, 2025 00:05
@jonrohan jonrohan requested a review from hectahertz May 21, 2025 00:05
Copilot
Copilot AI reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the old CSS modules feature flag from the SelectPanel2 experimental component, simplifying the code by always using the CSS module classes and replacing conditional styling branches with direct className usage.

  • Eliminates all useFeatureFlag checks and related branches
  • Replaces Box and Text wrappers with semantic HTML elements and CSS module classes
  • Adds className prop support to Panel and updates the changeset for a minor release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/experimental/SelectPanel2/SelectPanel.tsx Removed feature-flag branches, cleaned up imports, replaced Box/Text with div/span, added className prop
.changeset/famous-olives-smoke.md Updated changeset to remove the CSS modules feature flag under a minor release
Comments suppressed due to low confidence (1)

packages/react/src/experimental/SelectPanel2/SelectPanel.tsx:14

  • The import 'useFormControlForwardedProps' is no longer used in this file; consider removing it to clean up unused imports.
useFormControlForwardedProps,

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 21, 2025
@jonrohan jonrohan requested a review from joshblack May 21, 2025 15:44
@jonrohan jonrohan enabled auto-merge May 21, 2025 15:44
@jonrohan jonrohan added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit a007808 May 21, 2025
37 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag/selectpanel2 branch May 21, 2025 15:59
@primer primer bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@joshblack joshblack joshblack approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack