-
Notifications
You must be signed in to change notification settings - Fork 616
chore(AvatarStack): Remove the CSS module feature flag from the AvatarStack component #6052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: eee6906 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/379051 |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the CSS module feature flag from the AvatarStack component, consolidating on a single implementation using BoxWithFallback and CSS modules exclusively.
- Eliminates all styled-components, feature-flag toggles, and legacy utilities from AvatarStack.
- Refactors AvatarStack to wrap with BoxWithFallback and always apply CSS module classes.
- Updates Jest snapshots for AvatarStack (and unexpectedly CircleBadge) to match the new class names and markup.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/CircleBadge/snapshots/CircleBadge.test.tsx.snap | Refreshed CSS module class names in CircleBadge snapshots |
packages/react/src/AvatarStack/snapshots/AvatarStack.test.tsx.snap | Removed old CSS block, updated markup and class names for AvatarStack tests |
packages/react/src/AvatarStack/AvatarStack.tsx | Stripped out feature-flag logic, styled components, and legacy utilities; introduced BoxWithFallback and direct CSS module usage |
.changeset/loose-adults-thank.md | Added changeset noting removal of the CSS module feature flag |
Comments suppressed due to low confidence (1)
packages/react/src/CircleBadge/snapshots/CircleBadge.test.tsx.snap:4
- [nitpick] The CircleBadge snapshot updates seem unrelated to the AvatarStack feature-flag removal. Consider isolating these snapshot changes into a separate PR or including an explanation to keep reviews focused.
class="sc-hzhJZQ bXgcAI"
Closes https://github.com/github/primer/issues/4024
Changelog
New
Changed
Removed
Remove the CSS module feature flag from the AvatarStack component
Rollout strategy
Testing & Reviewing
Merge checklist