fix(Button): correct loading alignment

[francinelucca]

Closes https://github.com/github/primer/issues/5199

Changelog

Changed

• Add display flex to LoadingSpinner class in button

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: b8796ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[Copilot]

Pull Request Overview

This PR fixes the alignment of the loading spinner inside the Button component by making the spinner container a flexbox.

• Added display: flex to the .LoadingSpinner class.

Comments suppressed due to low confidence (2)

packages/react/src/Button/ButtonBase.module.css:246

• [nitpick] Verify that this class name matches the JSX import (e.g., styles.loadingSpinner). If the component expects camelCase, consider renaming to loadingSpinner to avoid mismatches.

.LoadingSpinner{

packages/react/src/Button/ButtonBase.module.css:246

• Consider adding a visual regression or Storybook test for the button with a loading spinner to catch any future alignment regressions.

.LoadingSpinner{

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	94.42 KB (0%)
packages/react/dist/browser.umd.js	94.48 KB (0%)

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/379073

[primer-integration]

🟢 golden-jobs completed with status success.

[hectahertz]

Pre approving, have a look at the copilot suggestions!

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[Copilot]

Pull Request Overview

This PR fixes the alignment of the loading spinner within the Button component by making its container a flexbox. It updates the CSS module, refreshes a test snapshot to reflect new class hashes, and adds a changeset for a patch release.

• Added .LoadingSpinner styles to center the spinner in buttons
• Updated an AnchoredOverlay snapshot due to updated CSS module class names
• Created a changeset entry for the patch release

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/react/src/Button/ButtonBase.module.css	Added .LoadingSpinner flex alignment rules
packages/react/src/AnchoredOverlay/snapshots/AnchoredOverlay.test.tsx.snap	Updated class hashes in snapshot
.changeset/light-pants-listen.md	Added patch changeset for fix(Button): correct loading alignment

Comments suppressed due to low confidence (1)

packages/react/src/Button/ButtonBase.module.css:247

• Consider adding a unit or visual regression test that renders a Button with isLoading enabled and asserts the spinner is centered, ensuring this new alignment is covered by automated tests.

display: flex;

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!