Skip to content

Addinng more properties to playground story for token & skeletonText #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented May 21, 2025

Changelog

This pull request updates the Token component's Storybook stories to enhance the Playground story with additional props and interactivity. The changes include adding new controls for boolean props, integrating actions for event handlers, and supporting a leading visual icon.

Also add more properties to SkeletonText playground story

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    Just updating storybook story.

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 07:50
@lukasoppermann lukasoppermann requested a review from a team as a code owner May 21, 2025 07:50
Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: e494a26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Token component’s Storybook Playground by adding new boolean controls, event actions, and support for a leading icon.

  • Added imports for action (Storybook addon) and GitBranchIcon
  • Updated the Playground story to conditionally hook up onRemove/onClick actions and render a leading icon
  • Extended Playground.args and argTypes with isSelected, leadingVisual, hideRemoveButton, onRemove, and onClick

Copy link
Contributor

github-actions bot commented May 21, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.42 KB (0%)
packages/react/dist/browser.umd.js 94.48 KB (0%)

@lukasoppermann lukasoppermann changed the title Addinng more proeprties to playground story for token Addinng more properties to playground story for token & skeletonText May 21, 2025
@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label May 21, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6096 May 21, 2025 11:50 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6096 May 21, 2025 12:04 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6096 May 22, 2025 03:13 Abandoned
@lukasoppermann lukasoppermann added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit 345868a May 22, 2025
35 checks passed
@lukasoppermann lukasoppermann deleted the tokenStorybook branch May 22, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants