Skip to content

Improvement to storybook stories #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

Improvement to storybook stories #6114

merged 4 commits into from
May 28, 2025

Conversation

lukasoppermann
Copy link
Contributor

Improving the controls for banner, IssueLabel and Label stories in Storybook.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    Just a minor tweak to storybook

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings May 23, 2025 07:59
@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label May 23, 2025
@lukasoppermann lukasoppermann requested a review from a team as a code owner May 23, 2025 07:59
Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: 20150ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines Storybook controls for Banner, IssueLabel, and Label components:

  • Switches variant controls from radio to dropdown select for IssueLabel and Label stories
  • Adds a new hideTitle boolean control to the Banner story

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/react/src/experimental/IssueLabel/IssueLabel.stories.tsx Changed variant control from inline-radio to select
packages/react/src/Label/Label.stories.tsx Updated control type from inline-radio to select
packages/react/src/Banner/Banner.stories.tsx Introduced hideTitle boolean control with default

@@ -72,6 +72,10 @@ export const Playground: StoryObj<typeof Banner> = {
control: 'text',
defaultValue: 'Banner title',
},
hideTitle: {
control: 'boolean',
defaultValue: false,
Copy link
Preview

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure the default value is applied when the story loads, you might move defaultValue: false into the story's args (e.g., Playground.args = { hideTitle: false }) instead of relying solely on argTypes.

Suggested change
defaultValue: false,

Copilot uses AI. Check for mistakes.

Copy link
Contributor

github-actions bot commented May 23, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.34 KB (0%)
packages/react/dist/browser.umd.js 94.5 KB (0%)

@lukasoppermann lukasoppermann enabled auto-merge May 27, 2025 12:30
@github-actions github-actions bot requested a deployment to storybook-preview-6114 May 27, 2025 12:33 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6114 May 27, 2025 12:48 Inactive
@lukasoppermann lukasoppermann removed the request for review from francinelucca May 27, 2025 15:07
@lukasoppermann lukasoppermann added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 2443627 May 28, 2025
33 of 34 checks passed
@lukasoppermann lukasoppermann deleted the storybook-updates branch May 28, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants