docs: update testing docs for vrt

[joshblack]

Closes https://github.com/github/primer/issues/5249

Changelog

New

Changed

• Add a note to our VRT testing docs to include running storybook

Removed

• Remove our old docs on running storybook tests

Rollout strategy

• None; if selected, include a brief description as to why

This is a change to contributor docs

[changeset-bot]

⚠️ No Changeset found

Latest commit: 61870c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Copilot]

Pull Request Overview

This PR updates the testing documentation to clarify that Storybook must be running before Visual Regression Tests and removes the outdated Storybook tests guide.

• Adds a note in testing.md to ensure Storybook is running locally before tests
• Deletes the old storybook-tests.md file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
contributor-docs/testing.md	Clarify requirement for Storybook to be running
contributor-docs/storybook-tests.md	Remove deprecated Storybook tests documentation

Comments suppressed due to low confidence (2)

contributor-docs/testing.md:113

• The markdown bullet is missing a space after the dash and "setup" should be split into the verb form "set up". Consider changing to - section to set up your machine. You also need Storybook to be running locally before running any tests.

-section to setup your machine. You also need Storybook to be running locally before running any tests.

contributor-docs/storybook-tests.md:1

• Ensure that all links or references to contributor-docs/storybook-tests.md have been updated or removed elsewhere in the docs to prevent broken links.

entire file removal

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	94.36 KB (0%)
packages/react/dist/browser.umd.js	94.55 KB (0%)

[francinelucca]

did running script/test-e2e work for you @joshblack I was runnign into errors when i tried despite running docker and storybook

[joshblack]

@francinelucca I opened up: #6142 for this to fix it, seems like a change to vitest caused it to no longer work 🤔

[francinelucca]

perfect! thanksss