-
Notifications
You must be signed in to change notification settings - Fork 616
Add disableFullscreenOnNarrow prop to SelectPanel for opt-out of fullscreen behavior #6138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 879b907 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…behavior Co-authored-by: francinelucca <[email protected]>
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Co-authored-by: francinelucca <[email protected]>
Done! I've renamed the prop to
I've also documented the new prop in |
Co-authored-by: francinelucca <[email protected]>
@copilot update the PR title and description to the new prop name |
Co-authored-by: francinelucca <[email protected]>
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be patch -> minor since we're adding functionality based on: https://github.com/primer/react/blob/main/contributor-docs/versioning.md#:~:text=Props-,A%20prop%20is%20added,-minor
Co-authored-by: Josh Black <[email protected]>
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
1 similar comment
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
The changeset version has been updated from patch to minor per versioning guidelines for adding new props. The PR now uses the appropriate bump level.
The |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
This PR adds a new
disableFullscreenOnNarrow?: boolean
prop to the SelectPanel component that allows users to opt out of the fullscreen behavior on narrow viewports.Changes
disableFullscreenOnNarrow
prop: New optional boolean prop inSelectPanelBaseProps
interfaceprimer_react_select_panel_fullscreen_on_narrow
feature flagBehavior
disableFullscreenOnNarrow ={true}
: Panel maintains anchored position on narrow viewportsdisableFullscreenOnNarrow ={false}
: Panel goes fullscreen on narrow viewports (if feature flag enabled)fullScreenOptOut={undefined}
: Follows theprimer_react_select_panel_fullscreen_on_narrow
feature flagTesting
Added comprehensive tests covering all three scenarios:
false
overrides enabled feature flagtrue
with enabled feature flagundefined
uses feature flag defaultAll existing tests continue to pass, ensuring no breaking changes.
Fixes #6137.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.