Skip to content

Remove explicit npm version from package.json #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented May 29, 2025

Remove the explicit npm cli version that we have in our root package.json. This was to prevent npm@11 being downloaded which was causing flakiness in our CI suite 😅

Hopefully with the recent releases of npm@11 this issue has gone away. If not, we can revert this change.

Copy link

changeset-bot bot commented May 29, 2025

⚠️ No Changeset found

Latest commit: f19d1bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 29, 2025
Copy link
Contributor

github-actions bot commented May 29, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.49 KB (0%)
packages/react/dist/browser.umd.js 94.6 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-6141 May 29, 2025 19:30 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label May 29, 2025
@joshblack joshblack marked this pull request as ready for review May 30, 2025 16:20
@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 16:20
@joshblack joshblack requested a review from a team as a code owner May 30, 2025 16:20
@joshblack joshblack requested a review from francinelucca May 30, 2025 16:20
@joshblack joshblack enabled auto-merge May 30, 2025 16:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the explicit npm CLI version (“packageManager”) from the root package.json to avoid CI flakiness caused by npm@11 downloading.
Key changes:

  • Deleted the pinned packageManager field from package.json
Comments suppressed due to low confidence (1)

package.json:110

  • [nitpick] Consider updating related contributor or setup documentation (e.g., README or CONTRIBUTING.md) to note that npm is no longer pinned in package.json, so developers know which npm versions are supported/recommended.
"packageManager": "[email protected]+sha512.8ab88f10f224a0c614cb717a7f7c30499014f77134120e9c1f0211ea3cf3397592cbe483feb38e0c4b3be1c54e347292c76a1b5edb94a3289d5448484ab8ac81"

@joshblack joshblack added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit ee6e76f May 30, 2025
36 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch May 30, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants