Skip to content

chore: Remove unnecessary theme providers #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

chore: Remove unnecessary theme providers #6224

merged 3 commits into from
Jun 23, 2025

Conversation

francinelucca
Copy link
Member

Closes #4514

@Copilot Copilot AI review requested due to automatic review settings June 20, 2025 02:39
@francinelucca francinelucca requested a review from a team as a code owner June 20, 2025 02:39
@francinelucca francinelucca requested a review from liuliu-dev June 20, 2025 02:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 57f2f42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added the skip changeset This change does not need a changelog label Jun 20, 2025
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copilot
Copilot AI reviewed Jun 20, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary ThemeProvider wrappers and unused theme imports from various test files, simplifying test setups now that the default theme is applied globally.

  • Deleted ThemeProvider imports and wrapping components in tests.
  • Removed unused theme imports where applicable.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/experimental/SelectPanel2/SelectPanel.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/tests/deprecated/ActionList.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/TreeView/TreeView.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/TooltipV2/tests/Tooltip.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/SplitPageLayout/SplitPageLayout.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/PageLayout/PageLayout.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/NavList/NavList.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/AnchoredOverlay/AnchoredOverlay.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/ActionList/Heading.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/ActionList/Group.test.tsx Removed ThemeProvider import and wrapper
packages/react/src/ActionList/ActionList.test.tsx Removed ThemeProvider import and wrapper

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.67 KB (0%)
packages/react/dist/browser.umd.js 92.54 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6224 June 20, 2025 02:46 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6224 June 20, 2025 03:00 Inactive
@francinelucca francinelucca mentioned this pull request Jun 20, 2025
Closed
@francinelucca francinelucca requested a review from TylerJDev June 20, 2025 04:08
@francinelucca francinelucca added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 1c2370a Jun 23, 2025
35 checks passed
@francinelucca francinelucca deleted the chore/remove-unnecessary-theme-providers branch June 23, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev TylerJDev approved these changes

@liuliu-dev liuliu-dev Awaiting requested review from liuliu-dev liuliu-dev is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests: Remove redundant ThemeProvider from tests
3 participants
@francinelucca @joshblack @TylerJDev