Skip to content

chore: Delete the toggleStyledComponent utility we used for CSS modules feature flags #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jul 8, 2025

This deletes the toggleStyledComponent utility function we used to toggle when we had the CSS modules feature flags. This is no longer in use anywhere

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 20:15
@jonrohan jonrohan added the skip changeset This change does not need a changelog label Jul 8, 2025
@jonrohan jonrohan requested a review from a team as a code owner July 8, 2025 20:15
@jonrohan jonrohan requested a review from joshblack July 8, 2025 20:15
Copy link

changeset-bot bot commented Jul 8, 2025

⚠️ No Changeset found

Latest commit: 9b0a058

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the toggleStyledComponent utility function and its associated tests, which were previously used for CSS modules feature flag toggles but are no longer needed.

  • Deletes the toggleStyledComponent utility function that was used to conditionally render styled components based on feature flags
  • Removes the corresponding test file that validated the utility's functionality
  • Cleans up legacy code from the CSS modules feature flag implementation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/internal/utils/toggleStyledComponent.tsx Complete removal of the utility function that handled conditional rendering of styled vs plain components
packages/react/src/internal/utils/__tests__/toggleStyledComponent.test.tsx Deletion of comprehensive test suite covering all functionality of the removed utility

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Jul 8, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.02 KB (0%)
packages/react/dist/browser.umd.js 92.23 KB (0%)

@jonrohan jonrohan added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 5f782f9 Jul 10, 2025
41 of 42 checks passed
@jonrohan jonrohan deleted the delete_toggleStyledComponent branch July 10, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants