Skip to content

Updating snapshots #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025
Merged

Updating snapshots #3613

merged 3 commits into from
Jul 31, 2025

Conversation

jonrohan
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 16:29
@jonrohan jonrohan requested a review from a team as a code owner July 31, 2025 16:29
@jonrohan jonrohan requested a review from pksjce July 31, 2025 16:29
Copy link

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Latest commit: ca8a834

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test snapshots, likely after changes to component rendering or test expectations. The changeset indicates this is a patch-level change for the @primer/view-components package.

  • Updates test snapshots to reflect current component output
  • Adds a changeset to document the snapshot updates as a patch release

Copy link
Contributor

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@github-actions github-actions bot requested a review from a team as a code owner July 31, 2025 17:01
@github-actions github-actions bot requested a review from langermank July 31, 2025 17:01
@jonrohan jonrohan merged commit 0ddc1a4 into main Jul 31, 2025
@jonrohan jonrohan deleted the updating_snapshots branch July 31, 2025 17:04
@primer primer bot mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant