Skip to content

General improvements (2025-11-08) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ixfd64 merged 3 commits into from
Nov 10, 2025
Merged

General improvements (2025-11-08) #92

ixfd64 merged 3 commits into from
Nov 10, 2025

Conversation

@ixfd64
Copy link
Member

@ixfd64 ixfd64 commented Nov 9, 2025 •
edited
Loading

  • improved the checkpoint code
    • converted some hard-coded values to macros
    • renamed some variables to be more descriptive
    • fixed grammar for cases where one factor is reported
    • replaced inefficient buffer initialization code
  • added missing license header to create_dependencies.sh

@ixfd64 ixfd64 requested review from N-Storm and brubsby November 9, 2025 02:19
@ixfd64 ixfd64 added the enhancement New feature or request label Nov 9, 2025
tdulcet
tdulcet reviewed Nov 9, 2025
View reviewed changes
N-Storm
N-Storm requested changes Nov 10, 2025
View reviewed changes
@ixfd64 @N-Storm
Apply suggestions from code review
7538831 
Co-authored-by: N-Storm <7067588+N-Storm@users.noreply.github.com>
@ixfd64 ixfd64 requested a review from N-Storm November 10, 2025 03:13
@ixfd64 ixfd64 merged commit a6eb92f into primesearch:main Nov 10, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdulcet tdulcet tdulcet left review comments

@N-Storm N-Storm N-Storm approved these changes

@brubsby brubsby Awaiting requested review from brubsby

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ixfd64 @N-Storm @tdulcet