-
Notifications
You must be signed in to change notification settings - Fork 14
add Linux shell script for launching multiple instances #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
N-Storm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the missing check during $APP symlink creation and the unconditional rm $APP that appears later, the rest is optional. Feel free to skip the other suggestions if you believe there are valid reasons to keep the current behavior.
Co-authored-by: N-Storm <[email protected]>
Fixed trivial: missing closing double quote
N-Storm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've noted one small typo (missed closing double quote in one echo statement), fixed and committed. Rest looks fine now for me.
tdulcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some miscellaneous suggestions. Please feel free to ignore.
README.txt
Outdated
| On remote systems, processes are killed when a session disconnects. To prevent | ||
| this, use a terminal multiplexer such as tmux or GNU Screen to detach and | ||
| reattach sessions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention nohup as a simpler alternative.
I'll hold off on merging this PR for now as some of those suggestions should definitely be implemented. |
Co-authored-by: Teal Dulcet <[email protected]>
|
I've implemented all the suggestions. Please me know if you have any further suggestions. |
tdulcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor follow up suggestions.
Co-authored-by: Teal Dulcet <[email protected]>
Co-authored-by: N-Storm <[email protected]>
Added a shell script for easily launching multiple instances on Linux systems. I was planning to add this to my own repo, but @N-Storm suggested putting it in a
contribfolder: https://mersenneforum.org/node/9313?p=1092889#post1092889I also made some changes to the documentation:
-doption