Skip to content

Conversation

@ixfd64
Copy link
Member

@ixfd64 ixfd64 commented Dec 7, 2025

Added a shell script for easily launching multiple instances on Linux systems. I was planning to add this to my own repo, but @N-Storm suggested putting it in a contrib folder: https://mersenneforum.org/node/9313?p=1092889#post1092889

I also made some changes to the documentation:

  • moved the information on running multiple instances from the FAQ to its own section
  • added more details about the -d option
  • added a tip for running mfaktc on remote systems

@ixfd64 ixfd64 requested review from N-Storm and brubsby December 7, 2025 23:30
@ixfd64 ixfd64 added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 7, 2025
Copy link
Member

@N-Storm N-Storm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing check during $APP symlink creation and the unconditional rm $APP that appears later, the rest is optional. Feel free to skip the other suggestions if you believe there are valid reasons to keep the current behavior.

Fixed trivial: missing closing double quote
@N-Storm N-Storm self-requested a review December 8, 2025 09:35
N-Storm
N-Storm previously approved these changes Dec 8, 2025
Copy link
Member

@N-Storm N-Storm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've noted one small typo (missed closing double quote in one echo statement), fixed and committed. Rest looks fine now for me.

Copy link
Member

@tdulcet tdulcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some miscellaneous suggestions. Please feel free to ignore.

README.txt Outdated
Comment on lines 189 to 191
On remote systems, processes are killed when a session disconnects. To prevent
this, use a terminal multiplexer such as tmux or GNU Screen to detach and
reattach sessions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention nohup as a simpler alternative.

@ixfd64
Copy link
Member Author

ixfd64 commented Dec 8, 2025

Some miscellaneous suggestions. Please feel free to ignore.

I'll hold off on merging this PR for now as some of those suggestions should definitely be implemented.

@ixfd64 ixfd64 marked this pull request as draft December 8, 2025 18:16
@ixfd64 ixfd64 marked this pull request as ready for review December 8, 2025 19:14
@ixfd64
Copy link
Member Author

ixfd64 commented Dec 8, 2025

I've implemented all the suggestions. Please me know if you have any further suggestions.

@ixfd64 ixfd64 requested review from N-Storm and tdulcet December 8, 2025 19:14
Copy link
Member

@tdulcet tdulcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor follow up suggestions.

@ixfd64 ixfd64 merged commit f1f6d1b into primesearch:main Dec 10, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants