Skip to content

Checksum errors from uninitialized variable #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ixfd64 merged 2 commits into from
Oct 20, 2025
Merged

Checksum errors from uninitialized variable #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5fc25a
checksum errors from uninitialized variable
JamesHeinrich Oct 20, 2025
ae0e875
Update README.txt
ixfd64 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
** Preface for mfakto 0.16.0-beta.4 **
** Preface for mfakto 0.16.0-beta.5 **

This is a developmental version of mfakto. It has been verified to produce
correct results. However, there may be bugs and incomplete features, and
Expand Down
2 changes: 1 addition & 1 deletion src/mfakto.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ void set_gpu_type()
printf("Warning: Unknown GPU name, assuming a GCN (Graphics Core Next) device. Please\n"
" post the name to the GIMPS forum or GitHub to have it added to mfakto.\n\n"
" Device name: %s (%s)\n"
" mfakto thread: http://mersenneforum.org/showthread.php?t=15646\n"
" mfakto thread: https://www.mersenneforum.org/node/11037\n"
" GitHub: https://github.com/primesearch/mfakto/issues\n\n"
" You can also set GPUType in %s to avoid this message.\n",
deviceinfo.d_name, deviceinfo.v_name, mystuff.inifile);
Expand Down
5 changes: 2 additions & 3 deletions src/output.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ void print_result_line(mystuff_t *mystuff, int factorsfound)
char factors_list[500];
char factors_quote_list[500];
char osjson[200];
char details[50];
char txtstring[200];
char json_checksum_string[750];
char timestamp[50];
Expand Down Expand Up @@ -609,8 +608,8 @@ void print_result_line(mystuff_t *mystuff, int factorsfound)
mystuff->exponent, mystuff->bit_min, mystuff->bit_max_stage,
MFAKTO_VERSION, mystuff->stats.kernelname);
}
snprintf(json_checksum_string, sizeof(json_checksum_string), "%u;TF;%s;;%d;%d;%u;;;mfakto;%s;%s;%s;%s;%s;%s", mystuff->exponent,
factors_list, mystuff->bit_min, mystuff->bit_max_stage, !partialresult, SHORT_MFAKTO_VERSION, mystuff->stats.kernelname, details,
snprintf(json_checksum_string, sizeof(json_checksum_string), "%u;TF;%s;;%d;%d;%u;;;mfakto;%s;%s;;%s;%s;%s", mystuff->exponent,
factors_list, mystuff->bit_min, mystuff->bit_max_stage, !partialresult, SHORT_MFAKTO_VERSION, mystuff->stats.kernelname,
getOS(), getArchitecture(), timestamp);
json_checksum = crc32_checksum(json_checksum_string, strlen(json_checksum_string));
sprintf(jsonstring, "{\"exponent\":%u, \"worktype\":\"TF\", \"status\":\"%s\", \"bitlo\":%d, \"bithi\":%d, \"rangecomplete\":%s%s, \"program\":{\"name\":\"mfakto\", \"version\":\"%s\", \"kernel\":\"%s\"}, \"timestamp\":\"%s\"%s%s%s%s, \"checksum\":{\"version\":%u, \"checksum\":\"%08X\"}}",
Expand Down
2 changes: 1 addition & 1 deletion src/params.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ than an equal SIEVE_SIZE_LIMIT #define.
Please discuss with the community before making changes to version numbers!
*/

#define SHORT_MFAKTO_VERSION "0.16.0-beta.4"
#define SHORT_MFAKTO_VERSION "0.16.0-beta.5"

#ifdef _MSC_VER
#define MFAKTO_VERSION "mfakto " SHORT_MFAKTO_VERSION "-Win"
Expand Down
Loading