convert hard-coded values to macros #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Storm
reviewed
Nov 27, 2025
src/params.h
Outdated
| /* For worktodo.txt files */ | ||
| #define MAX_LINE_LENGTH 100 | ||
| /* settings related to worktodo.txt file */ | ||
| #define WORKTODO_FILE "worktodo.txt" |
Member
There was a problem hiding this comment.
I suggest leaving a comment here, that WORKTODO_FILE string length shouldn't exceed 50 characters (as per my_types.h)
Same for the other string constants for file names below.
Co-authored-by: N-Storm <[email protected]>
N-Storm
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted some hard-coded values to macros, to prepare for potential future changes.
I also made a few additional changes:
mfaktc.initomfakto.iniin two placeswc2 - wctwice inmyfnmatch.c