Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new guide regarding nuxt+ppg+vercel (#DA-2255) #6589

Merged
merged 32 commits into from
Jan 21, 2025
Merged

feat: add new guide regarding nuxt+ppg+vercel (#DA-2255) #6589

merged 32 commits into from
Jan 21, 2025

Conversation

ankur-arch
Copy link
Contributor

No description provided.

@ankur-arch ankur-arch requested a review from jharrell January 11, 2025 02:01
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 11, 2025 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: badfbbe
Status: ✅  Deploy successful!
Preview URL: https://7a695d69.docs-51g.pages.dev
Branch Preview URL: https://da-2255.docs-51g.pages.dev

View logs

@ankur-arch ankur-arch self-assigned this Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

original preview
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx
content/200-orm/800-more/600-help-and-troubleshooting/900-prisma-nuxt-module.mdx content/200-orm/800-more/600-help-and-troubleshooting/900-prisma-nuxt-module.mdx

@github-actions GitHub Actions
Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@github-actions GitHub Actions
Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 20.6%, saving 68.74 KB.

Filename Before After Improvement Visual comparison
static/img/guides/prisma-postgres-and-prisma-nuxt-guide.png 334.22 KB 265.48 KB -20.6% View diff

168 images did not require optimisation.

@ankur-arch ankur-arch changed the title feat: add new guide regarding nuxt+ppg+vercel (#DA-255) feat: add new guide regarding nuxt+ppg+vercel (#DA-2255) Jan 11, 2025
@ankur-arch ankur-arch added the docs Documentation creation, updates or corrections label Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 20.2%, saving 63.44 KB.

Filename Before After Improvement Visual comparison
static/img/guides/prisma-postgres-and-prisma-nuxt-guide.png 314.74 KB 251.30 KB -20.2% View diff

168 images did not require optimisation.

nikolasburk
nikolasburk requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Ankur! I was able to get through the guide and build + deploy my Nuxt app successfully with PPg 🎉

There were a few parts where I think the guide could be even more clear, so I left some comments and suggestions you can take a look at 🙌

content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
content/800-guides/1100-using-prisma-nuxt-module-with-prisma-postgres.mdx Outdated Show resolved Hide resolved
ankur-arch and others added 10 commits January 14, 2025 15:07
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
ce477e2 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
22e3921 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
127c2ba 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
d09df99 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
2809f35 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
430173d 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
dc91c68 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch
Merge branch 'main' into DA-2255
72c6216
@ankur-arch
fix: change indentations
5c261db
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
4dacacb 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
ankur-arch and others added 10 commits January 14, 2025 19:02
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
daa90c5 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
b63d2f1 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
ef6d84d 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
829b6ae 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
fbd8bbf 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch @nikolasburk
Update content/800-guides/1100-using-prisma-nuxt-module-with-prisma-p…
47ba921 
…ostgres.mdx

Co-authored-by: Nikolas <[email protected]>
@ankur-arch
fix: make final changes
b7e5db1
@ankur-arch
fix: fix the server here
2072898
@ankur-arch
feat: update image
0580c15
@github-actions
Optimised images with calibre/image-actions
e690595
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 22.8%, saving 65.16 KB.

Filename Before After Improvement Visual comparison
static/img/guides/prisma-postgres-and-prisma-nuxt-guide.png 286.38 KB 221.22 KB -22.8% View diff

168 images did not require optimisation.

@nikolasburk nikolasburk self-requested a review January 16, 2025 21:33
nikolasburk
nikolasburk requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great iteration 👏 found some tiny issues but once these are resolved this should be good to get merged 🙌

@nikolasburk nikolasburk self-requested a review January 21, 2025 14:10
nikolasburk
nikolasburk approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turned out great 🚀 Really nice work, Ankur!!

@jharrell jharrell merged commit f7ad950 into main Jan 21, 2025
12 checks passed
@jharrell jharrell deleted the DA-2255 branch January 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharrell jharrell jharrell approved these changes

@nikolasburk nikolasburk nikolasburk approved these changes

Assignees

@ankur-arch ankur-arch

Labels
docs Documentation creation, updates or corrections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankur-arch @nikolasburk @jharrell