Skip to content

Conversation

@mayank1513
Copy link
Contributor

@mayank1513 mayank1513 commented Jul 21, 2023

Fixes #4974

Refractor code to match community standards

  • Remove unnecessary React.FC syntax
  • Extract Layout to _app.tsx (No need to add layout on every page)
  • Use absolute path uniformly - remove import ../.., etc.

Update UI to reflect functionality properly

  • SignUp button should be renamed to "Add Author"
  • /signup route should be renamed to /add-author
  • On create post page, email input should be changed to select (As only those emails that exists in users table can be added there)
  • Remove legacyBehaviour and update links

Refractor code to match community standards
- Removed unnecessary React.FC syntax from components folder
- update .gitignore to ingore package-lock files
Refractor code to match community standards
- Extract Layout to _app.tsx
- removed long `../..` pattern
- makes refactoring/rearranging files easy
Refractor code to match community standards
- Removed unnecessary React.FC syntax from pages
- There is no login or signup mechanism.
- Signup button adds new author
- This commit simply renames UI text to reflect that more clearly
- Change authorEmail Input field to select
- This is much better as Author email must exist in users table
- fix imports
@mayank1513 mayank1513 closed this Jul 21, 2023
@mayank1513 mayank1513 reopened this Jul 21, 2023
@mayank1513
Copy link
Contributor Author

image

@mayank1513
Copy link
Contributor Author

Hi,

anybody here?

@mayank1513
Copy link
Contributor Author

Is this repo deprecated?

@jharrell jharrell requested review from jharrell and ruheni December 18, 2023 15:46
@jharrell
Copy link
Contributor

Hi there! Apologies for not seeing this back when you opened it. I tried my hand at fixing merge conflicts and failed spectacularly. If you're still interested in this, would you mind correcting the merge conflicts? I will then give this the go ahead.

@jharrell
Copy link
Contributor

Hello!

We are reviewing our old pull requests in this repo. If we believe that the PR is stale or abandoned, we're going to close them.

We'd still love to have your contribution! If you'd be willing to pick this PR back up, please just comment or open a new pull request and we'll hop on it 🙏

@jharrell jharrell closed this Dec 20, 2024
@mayank1513
Copy link
Contributor Author

hi

@jharrell jharrell reopened this Dec 20, 2024
@jharrell jharrell removed the request for review from ruheni December 20, 2024 18:14
@jharrell
Copy link
Contributor

Hi @mayank1513 and glad to have you back 😊

I'll take a look at resolving merge conflicts, but as our codebase has changed pretty significantly it might be difficult. Please bear with me!

@jharrell
Copy link
Contributor

Closing as superseded by #7402

@jharrell jharrell closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Next.js Rest API example

2 participants