ci: Complete dev container configuration #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaharagon
added
fix:python
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the development container and local build configuration, unifies navigation URLs via environment variables, and streamlines MkDocs config management.
- Introduces a Debian-based multi-stage Dockerfile and pins Pipenv dependencies into a project virtual environment.
- Refactors all MkDocs navigation entries and homepages to use
!ENVlookups and removes outdated net-site configs. - Adds a new
.devcontainer/devcontainer.jsonfor local development and updates GitHub Actions to export URL environment variables for production builds.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| run.sh | Use static mkdocs.insiders.yml instead of dynamic temp files |
| net/index.md | Removed legacy community index page |
| modules/mkdocs-material | Bumped submodule commit |
| mkdocs.yml | Converted blog/video nav entries to !ENV syntax for dynamic URLs |
| mkdocs.videos.yml | Updated homepage and nav to use !ENV variables |
| mkdocs.net.yml | Deleted obsolete net site configuration |
| mkdocs.insiders.yml | Added base MkDocs override for insiders preview |
| mkdocs.blog.yml | Changed homepage and nav entries to use !ENV lookups |
| Dockerfile | Switched from Alpine to Debian (bookworm) and implemented multi-stage build |
| .vscode/extensions.json | Updated VS Code recommended extensions list |
| .github/workflows/build.yml | Added step to export site URL environment variables for production |
| .devcontainer/devcontainer.json | Added new devcontainer definition with tasks for live previews |
Comments suppressed due to low confidence (1)
run.sh:115
- Using
if $insiderswill attempt to execute the variable rather than test its value; replace it with a test expression, for example:if [ "$insiders" = true ]; then.
if $insiders ; then
✅ Your preview is ready!
|
jonaharagon
added a commit
that referenced
this pull request
Jun 5, 2025
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
force-pushed
the
upgrade-deps
branch
3 times, most recently
from
1a90180 to
87a6fe1
Compare
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
added a commit
that referenced
this pull request
Jun 6, 2025
jonaharagon
force-pushed
the
upgrade-deps
branch
from
dcc6880 to
fd0d995
Compare
|
This pull request has been mentioned on Privacy Guides Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developing locally with Docker is now fully functional and covers all website builds (including blogs and videos).