Add docker-compose testnet #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds Makefile targets for running a local deployment of talek with podman and docker-compose. testnet-start: starts a talek deployment testnet-stop: stops the deployment testnet-build-config: builds configuration with talekutil testnet-clean: cleans images and stampfiles testnet-cli: starts a shell with talek cli programs
|
After manually editing talek.json to point at the frontend instance listening on :8080 I wasn't able to read/write data using talekclient. For example: |
|
You should be able to replicate this by using the Makefile target testnet-start and testnet-cli, where the client configuration is written to /talek_net/talek.json inside the container |
willscott
approved these changes
Mar 9, 2024
talek_net/docker-compose.yml
Outdated
| restart: "no" | ||
| image: talek | ||
| volumes: | ||
| - ./:/talek_net |
There was a problem hiding this comment.
maybe make the volume talek_shared_mnt or something that disambiguates from the docker network net?
There was a problem hiding this comment.
I changed the volume path to talek_shared
instead of requiring a python docker image
- use default config file names - use docker workdir - escape quotes so sed line actually works - fix port number
This works for me right now, but I don't know why I need to fork the log handle into a reader and a writer the way I am here before using it. If I read and write using the same handle (without making a copy of it first), the read operations always read from the locations --write would write to *next*, rather than the previous locations which have actually been written to. So, there is either an off-by-one error somewhere or I am confused about how this is supposed to work.
- allow stopping and restarting without regenerating configs - make testnet-test-write-and-read target depend on the network being up
After merging masala's fix for parsing read-only handles from privacylab#110 this works now.
|
Is this a a point that's ready for a review? |
Yes please. Note that this has the fix from the other open PR (#110) merged to make the write-and-read integration test work. Let me know if you're actually running travis somewhere and I could add it to |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Makefile targets to start and stop a local talek deployment using docker-compose and podman or docker. It provides a docker-compose.yml and writes a client configuration file for use with talekclient.